Skip to content

Corrected lut mode #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akx merged 3 commits into from
Aug 7, 2024
Merged

Corrected lut mode #7

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20e46cd
Corrected lut mode
radarhere Aug 7, 2024
aa0f0c8
Concatenate parameters into single string
radarhere Aug 7, 2024
9170f8f
Added channels parameter
radarhere Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions Tests/test_color_lut.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,67 +106,67 @@ def test_wrong_args(self) -> None:
im.im.color_lut_3d("RGB", Image.Resampling.BILINEAR, 3, 2, 2, 2, 16)

@pytest.mark.parametrize(
("lut_mode", "table_size"),
"lut_mode, table_channels, table_size",
[
("RGB", (3, 3)),
("CMYK", (4, 3)),
("RGB", (3, (2, 3, 3))),
("RGB", (3, (65, 3, 3))),
("RGB", (3, (3, 65, 3))),
("RGB", (3, (3, 3, 65))),
("RGB", 3, 3),
("CMYK", 4, 3),
("RGB", 3, (2, 3, 3)),
("RGB", 3, (65, 3, 3)),
("RGB", 3, (3, 65, 3)),
("RGB", 3, (2, 3, 65)),
],
)
def test_correct_args(
self, lut_mode: str, table_size: tuple[int, int | tuple[int, int, int]]
self, lut_mode: str, table_channels: int, table_size: int | tuple[int, int, int]
) -> None:
im = Image.new("RGB", (10, 10), 0)
assert im.im is not None
im.im.color_lut_3d(
lut_mode,
Image.Resampling.BILINEAR,
*self.generate_identity_table(*table_size),
*self.generate_identity_table(table_channels, table_size),
)

@pytest.mark.parametrize(
("image_mode", "lut_mode", "table_size"),
"image_mode, lut_mode, table_channels, table_size",
[
("L", "RGB", (3, 3)),
("RGB", "L", (3, 3)),
("L", "L", (3, 3)),
("RGB", "RGBA", (3, 3)),
("RGB", "RGB", (4, 3)),
("L", "RGB", 3, 3),
("RGB", "L", 3, 3),
("L", "L", 3, 3),
("RGB", "RGBA", 3, 3),
("RGB", "RGB", 4, 3),
],
)
def test_wrong_mode(
self, image_mode: str, lut_mode: str, table_size: tuple[int, int]
self, image_mode: str, lut_mode: str, table_channels: int, table_size: int
) -> None:
with pytest.raises(ValueError, match="wrong mode"):
im = Image.new(image_mode, (10, 10), 0)
assert im.im is not None
im.im.color_lut_3d(
lut_mode,
Image.Resampling.BILINEAR,
*self.generate_identity_table(*table_size),
*self.generate_identity_table(table_channels, table_size),
)

@pytest.mark.parametrize(
("image_mode", "lut_mode", "table_size"),
"image_mode, lut_mode, table_channels, table_size",
[
("RGBA", "RGB", (3, 3)),
("RGBA", "RGBA", (4, 3)),
("RGB", "HSV", (3, 3)),
("RGB", "RGBA", (4, 3)),
("RGBA", "RGBA", 3, 3),
("RGBA", "RGBA", 4, 3),
("RGB", "HSV", 3, 3),
("RGB", "RGBA", 4, 3),
],
)
def test_correct_mode(
self, image_mode: str, lut_mode: str, table_size: tuple[int, int]
self, image_mode: str, lut_mode: str, table_channels: int, table_size: int
) -> None:
im = Image.new(image_mode, (10, 10), 0)
assert im.im is not None
im.im.color_lut_3d(
lut_mode,
Image.Resampling.BILINEAR,
*self.generate_identity_table(*table_size),
*self.generate_identity_table(table_channels, table_size),
)

def test_identities(self) -> None:
Expand Down