-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Feature/7582 #7595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/7582 #7595
Conversation
Although the way this supervision strategy configuration method will work. Sadly we dont enforce some kind of Init callback for our snapshot or journal implementations. If we did, we could force all implementations to handle their setup in there, stuff like initializing connections and whatnot. Then if that fails we could provide out of the box detection for init failures and use custom exceptions to explicitly communicate initialization failure. But that would be a major breaking change for persistence plugin implementations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for the CI/CD to go through
Well done @Danthar - ty for your contribution |
Changes
Added a facility to provide your own supervision strategy that is used to govern the journal and snapshot-store plugins
This is a WIP. I need to probably add a configuration Spec, and some crash behavior tests at the very least.
Fixes #7582
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Latest
dev
Benchmarksnot relevant
This PR's Benchmarks
not relevant