Skip to content

Conversation

Danthar
Copy link
Member

@Danthar Danthar commented Apr 10, 2025

Changes

Added a facility to provide your own supervision strategy that is used to govern the journal and snapshot-store plugins

This is a WIP. I need to probably add a configuration Spec, and some crash behavior tests at the very least.

Fixes #7582

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Latest dev Benchmarks

not relevant

This PR's Benchmarks

not relevant

@Danthar
Copy link
Member Author

Danthar commented Apr 10, 2025

Although the way this supervision strategy configuration method will work. Sadly we dont enforce some kind of Init callback for our snapshot or journal implementations. If we did, we could force all implementations to handle their setup in there, stuff like initializing connections and whatnot. Then if that fails we could provide out of the box detection for init failures and use custom exceptions to explicitly communicate initialization failure.

But that would be a major breaking change for persistence plugin implementations.

@Danthar Danthar marked this pull request as draft April 11, 2025 07:43
@Danthar Danthar self-assigned this Apr 11, 2025
@Danthar Danthar marked this pull request as ready for review April 18, 2025 15:20
Copy link
Contributor

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for the CI/CD to go through

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) May 7, 2025 21:06
@Aaronontheweb Aaronontheweb disabled auto-merge May 7, 2025 21:07
@Aaronontheweb Aaronontheweb merged commit f67e123 into akkadotnet:dev May 8, 2025
7 of 11 checks passed
@Aaronontheweb
Copy link
Member

Well done @Danthar - ty for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to specifically detect persistence journal and/or snapshot initialisation failures
3 participants