Fix: Update for compliance with typescript 5.9.2 #5855
Conversation
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5855 +/- ##
=======================================
Coverage 87.84% 87.84%
=======================================
Files 622 622
Lines 46387 46387
Branches 7605 7605
=======================================
Hits 40749 40749
Misses 5638 5638
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
types/ace-modules.d.ts
Outdated
| /** | ||
| * - Gets the text to display for a given row | ||
| */ | ||
| getText: (arg0: EditSession, arg1: number) => string; |
There was a problem hiding this comment.
is there are reason why we call these arguments arg0... instead of editSession ...?
There was a problem hiding this comment.
yeah, it's in draft state... I am patching more generic solution, that would handle this for all event types, not only for onChangeSelection. But I'll take this into account and rename arguments
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts) and its references: