Skip to content

Add canvas context check in $updateDecorators method #5833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Jun 18, 2025

Issue #, if available:

Description of changes:
Guard check for environments where canvas doesn't have getContext method

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.73%. Comparing base (017341f) to head (71e6ddb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/ext/diff/scroll_diff_decorator.js 50.00% 1 Missing ⚠️
src/layer/decorators.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5833      +/-   ##
==========================================
- Coverage   87.74%   87.73%   -0.01%     
==========================================
  Files         618      618              
  Lines       46042    46046       +4     
  Branches     7547     7549       +2     
==========================================
+ Hits        40398    40400       +2     
- Misses       5644     5646       +2     
Flag Coverage Δ
unittests 87.73% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nightwing nightwing merged commit eb75438 into ajaxorg:master Jun 19, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants