Skip to content

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented May 18, 2025

What do these changes do?

This PR adds CI for Python 3.14. It skips tests which use isal as that doesn't has 3.14 wheels and is optional. I modified the requirements file to add markers to install isal and python-on-whales on less than Python 3.14 to fix the CI.

Are there changes in behavior for the user?

none

Is it a substantial burden for the maintainers to support this?

none

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

Copy link

codecov bot commented May 18, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.75%. Comparing base (48082a7) to head (6bdf956).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
tests/conftest.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10872      +/-   ##
==========================================
- Coverage   98.76%   98.75%   -0.01%     
==========================================
  Files         129      129              
  Lines       43416    43416              
  Branches     2324     2325       +1     
==========================================
- Hits        42879    42877       -2     
- Misses        383      384       +1     
- Partials      154      155       +1     
Flag Coverage Δ
CI-GHA 98.64% <60.00%> (-0.01%) ⬇️
OS-Linux 98.37% <60.00%> (-0.01%) ⬇️
OS-Windows 96.80% <60.00%> (+<0.01%) ⬆️
OS-macOS 97.68% <60.00%> (-0.01%) ⬇️
Py-3.10.11 97.33% <60.00%> (+<0.01%) ⬆️
Py-3.10.18 97.72% <60.00%> (+<0.01%) ⬆️
Py-3.11.13 97.91% <60.00%> (-0.02%) ⬇️
Py-3.11.9 97.52% <60.00%> (-0.01%) ⬇️
Py-3.12.10 97.62% <60.00%> (-0.02%) ⬇️
Py-3.12.11 98.01% <60.00%> (-0.01%) ⬇️
Py-3.13.5 98.27% <60.00%> (-0.02%) ⬇️
Py-3.9.13 97.22% <60.00%> (-0.01%) ⬇️
Py-3.9.23 97.61% <60.00%> (-0.01%) ⬇️
Py-pypy7.3.16 83.46% <60.00%> (-8.98%) ⬇️
VM-macos 97.68% <60.00%> (-0.01%) ⬇️
VM-ubuntu 98.37% <60.00%> (-0.01%) ⬇️
VM-windows 96.80% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 18, 2025

CodSpeed Performance Report

Merging #10872 will not alter performance

Comparing kumaraditya303:py314 (6bdf956) with master (48082a7)1

Summary

✅ 59 untouched benchmarks

Footnotes

  1. No successful run was found on master (02e5cf1) during the generation of this report, so 48082a7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@kumaraditya303 kumaraditya303 marked this pull request as ready for review May 18, 2025 20:03
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, we usually don't start testing until the deps are ready, which is closer to the final release of CPython.. Not sure if it's worth doing this PR just yet.

@kumaraditya303 kumaraditya303 changed the title add Python 3.14 to CI adjust dependencies for Python 3.14 Jul 26, 2025
@kumaraditya303 kumaraditya303 requested a review from webknjaz July 26, 2025 09:28
@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Jul 26, 2025

All tests passed on 3.14 now except tests/test_cookiejar.py::test_pickle_format which is failing on 3.14.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jul 26, 2025
@Dreamsorcerer Dreamsorcerer added the backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot label Aug 8, 2025
@Dreamsorcerer Dreamsorcerer merged commit ec38d25 into aio-libs:master Aug 8, 2025
39 of 41 checks passed
Copy link
Contributor

patchback bot commented Aug 8, 2025

Backport to 3.13: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply ec38d25 on top of patchback/backports/3.13/ec38d25c5a700e4ce798cbe2a91c969cb5d2deb5/pr-10872

Backporting merged PR #10872 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.13/ec38d25c5a700e4ce798cbe2a91c969cb5d2deb5/pr-10872 upstream/3.13
  4. Now, cherry-pick PR adjust dependencies for Python 3.14 #10872 contents into that branch:
    $ git cherry-pick -x ec38d25c5a700e4ce798cbe2a91c969cb5d2deb5
    If it'll yell at you with something like fatal: Commit ec38d25c5a700e4ce798cbe2a91c969cb5d2deb5 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x ec38d25c5a700e4ce798cbe2a91c969cb5d2deb5
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR adjust dependencies for Python 3.14 #10872 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.13/ec38d25c5a700e4ce798cbe2a91c969cb5d2deb5/pr-10872
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@kumaraditya303 kumaraditya303 deleted the py314 branch August 8, 2025 16:20
Dreamsorcerer pushed a commit that referenced this pull request Aug 9, 2025
Dreamsorcerer added a commit that referenced this pull request Aug 9, 2025
(cherry picked from commit ec38d25)

---------

Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants