Add tools property and entrypoint for workflows
#6884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6884 +/- ##
==========================================
+ Coverage 79.13% 79.17% +0.05%
==========================================
Files 565 567 +2
Lines 43391 43416 +25
==========================================
+ Hits 34331 34370 +39
+ Misses 9060 9046 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
agoscinski
force-pushed
the
feat/workchain-tools
branch
2 times, most recently
from
eedeba5 to
4980623
Compare
This is an implementation of feature request in issue aiidateam#6865. Further changes: * Extend the typing hints from `tools` output as it can return `None` * Add tests for `CalcJobNode.tools` and `WorkChainNode.tools` --------- Co-authored-by: Alexander Goscinski <[email protected]>
agoscinski
force-pushed
the
feat/workchain-tools
branch
from
4980623 to
cb9d61e
Compare
agoscinski
force-pushed
the
feat/workchain-tools
branch
from
259c2dd to
cb9d61e
Compare
for more information, see https://pre-commit.ci
…iida-core into feat/workchain-tools
for more information, see https://pre-commit.ci
|
@bastonero sorry I did not give you heads up. I wanted to merge it and was about to finalize it but then there was an error in the REST API which I was not able to fix in the time |
|
@agoscinski no worries, and thanks a lot! is there still this issue? do we need to add/do something else/more? |
|
@eimrek can you have a look? It is a test error in the REST API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6865