check all the keys for prototype pollution#6
Merged
Conversation
An prototype-pollution attack was still possible with the previous fix.
The method would crash, but the attack was still successful.
PoC:
```JavaScript
let obj = { foo: { bar: 'baz' } }
try {
obj = setIn(obj, ['__proto__', 'polluted'], 'success');
} catch (e) {
console.error(e);
}
console.log(({}).polluted);
```
Owner
|
wow, silly me! 😅 thanks @erik-krogh, i appreciate your pull request 💜 |
Owner
|
added another commit to clean things up: 34842cc. (this code should have the same effect, unless i'm being clueless again) 🧼 then published as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An prototype-pollution attack was still possible with the previous fix for CVE-2022-25354.
The method would crash, but the attack was still successful.
PoC: