fix: remove deprecated Tantivy FTS, fix Redis hset mypy error#8146
Merged
Conversation
LanceDB removed Tantivy-based FTS in v0.32.0 and now uses native FTS. This caused test_keyword_search and test_hybrid_search to fail with "Tantivy-based FTS has been removed" error. Changes: - LanceDB: default use_tantivy to False, remove passing it to create_fts_index(), emit deprecation warning if True passed - Redis: add convert_bytes() call (like other methods), fix mypy arg-type error by using Mapping[str, Any] and type: ignore - Remove tantivy from lancedb dependencies in pyproject.toml - Update cookbook install instructions to remove tantivy
ysolanky
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI failures on main caused by:
use_tantivy=Truewhich now raisesValueError.hset(mapping=metadata)wheremetadata: Dict[str, Any]was incompatible with stricter redis-py type stubs.Changes
LanceDB (
lance_db.py)use_tantivydefault fromTruetoFalseuse_tantivytocreate_fts_index()calls (lines 618, 644)use_tantivy=Trueis passedRedis (
redisdb.py)convert_bytes()call inupdate_metadata()to match other methodsDict[str, Any]toMapping[str, Any]# type: ignore[arg-type]for the redis-py stub incompatibilityDependencies (
pyproject.toml)tantivyfrom lancedb extrastantivy.*from mypy ignore listCookbooks
tantivyfrom install instructionsType of change
Checklist
./scripts/format.shpasses./scripts/validate.shpasses (no new mypy errors introduced)test_keyword_search,test_hybrid_search)