chore: drop unused available_models field from EvalsDomainConfig#7993
Merged
Conversation
The Evals UI "Evaluation model" dropdown is populated from the top-level AgentOSConfig.available_models field returned by GET /config (see libs/agno/agno/os/router.py:174 and libs/agno/agno/os/mcp.py:82). EvalsDomainConfig.available_models was declared but never read anywhere, so setting it inside evals.dbs[].domain_config was a silent no-op that misled users trying to populate the dropdown. Removing the field so the top-level config is the single supported path. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This was referenced May 19, 2026
kausmeows
approved these changes
May 19, 2026
harshsinha03
added a commit
to agno-agi/docs
that referenced
this pull request
May 20, 2026
## Description Documented `evals.available_models` and `evals.dbs[].domain_config.available_models` were never plumbed through on the SDK side — setting them was a silent no-op that left the Evals UI "Evaluation model" dropdown empty (the reported bug). The only path the frontend actually reads is the top-level `AgentOSConfig.available_models` returned by `GET /config` (sourced at `libs/agno/agno/os/router.py:174` and `libs/agno/agno/os/mcp.py:82`). This PR updates three places: - **`_snippets/agent-os-configuration-reference.mdx`** — drop the `available_models` row from the `EvalsConfig` parameter table. - **`agent-os/config.mdx`** — drop both the top-level `evals.available_models` and the nested `evals.dbs[].domain_config.available_models` from the YAML example; trim the misleading comment. - **`reference/agent-os/configuration.mdx`** — drop the same nested blocks from the YAML schema reference. After these edits, the only `available_models` mentioned in the docs is the legitimate top-level field (sibling of `evals:`, not nested under it). ## Type of Change - [x] Bug fix (errors, broken links, outdated info) - [ ] New content - [ ] Content improvement - [ ] Other: ____ ## Related Issues/PRs (if applicable) - Related SDK PR: agno-agi/agno#7993 ## Checklist - [x] Content is accurate and up-to-date - [x] All links tested and working (\`mint broken-links\` clean) - [x] Code examples verified (Python/YAML round-tripped through `TestClient` against `GET /config`) - [x] Spelling and grammar checked - [ ] Screenshots updated (not applicable) Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Evals UI "Evaluation model" dropdown is populated from the top-level
AgentOSConfig.available_modelsfield returned byGET /config(seelibs/agno/agno/os/router.py:174andlibs/agno/agno/os/mcp.py:82).EvalsDomainConfig.available_modelswas declared but never read anywhere in the codebase — setting it underevals.dbs[].domain_configThis PR removes the unused field. The top-level
AgentOSConfig.available_modelsbecomes the only supported path, matching what the frontend already consumes.Type of change
Checklist
./scripts/format.shand./scripts/validate.sh)Duplicate and AI-Generated PR Check