[ refactor ] Data.List.Relation.Binary.Sublist.Propositional.Properties
#2808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacquesCarette
requested changes
Aug 22, 2025
| @@ -167,7 +180,7 @@ lookup-⊆-trans = Any-resp-⊆-trans | |||
| lookup-injective : ∀ {P : Pred A ℓ} {τ : xs ⊆ ys} {i j : Any P xs} → | |||
| lookup τ i ≡ lookup τ j → i ≡ j | |||
| lookup-injective {τ = _ ∷ʳ _} = lookup-injective ∘′ there-injective | |||
| lookup-injective {τ = x≡y ∷ _} {here _} {here _} = cong here ∘′ subst-injective x≡y ∘′ here-injective | |||
| lookup-injective {τ = refl ∷ _} {here _} {here _} = cong here ∘′ here-injective | |||
There was a problem hiding this comment.
This change now makes the comment right after it not make sense?
|
|
||
| -- All P is a contravariant functor from _⊆_ to Set. | ||
|
|
||
| All-resp-⊆ : (All P) Respects _⊇_ |
There was a problem hiding this comment.
The name says the opposite of the property?!?!?
There was a problem hiding this comment.
The name is legacy, back-ported from Propositional. But I agree, it's maybe idiotic to have retained it.
Ah... yes, you're probably right. But as I comment on the original issue, it's perhaps not even obvious what the right way forward is here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2525 . This tackles the refactoring part, but does not resolve the duplication problem.
UPDATED: yuk... some tricky intensional equality snafus caused by the refactoring. FIXED now, but at the cost of a
breaking(intensional to extensional) change...Not only that, but attempting to deprecate
anti-mono/all-anti-monocauses a dependency cycle betweenData.List.Relation.Unary.All.PropertiesData.List.Relation.Binary.Subset.Propositional.PropertiesI'm tempted to suggest that we make the
breakingchange simply of moving the lemmas to the latter module, and marking this asnon-backwards-compatiblefor the sake of a simpler dependency graph?