Skip to content

Encoding should match scene's color management settings #5157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2022
Merged

Encoding should match scene's color management settings #5157

merged 1 commit into from
Nov 20, 2022

Conversation

diarmidmackenzie
Copy link
Contributor

@diarmidmackenzie diarmidmackenzie commented Nov 19, 2022 •
edited
Loading

Description:

Fix for #5014

Changes proposed:

  • encoding setting for screenshot is read from renderer, rather than assuming sRGB or Linear
  • unit tests to check interaction between colorManagement setting on scene, and encoding used in screenshots.

@dmarcos
Copy link
Member

dmarcos commented Nov 20, 2022

Thank you so much! 🏆 🥳

@dmarcos dmarcos merged commit 11bdac3 into aframevr:master Nov 20, 2022
This was referenced Nov 21, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diarmidmackenzie @dmarcos