Use background to set the default environment map #4797
Conversation
|
For the future this could also be updated to support the environment cube maps generated by WebXR Lighting Estimation: |
| @@ -5,7 +5,8 @@ var COMPONENTS = require('../../core/component').components; | |||
| module.exports.Component = register('background', { | |||
| schema: { | |||
| color: {type: 'color', default: 'black'}, | |||
| transparent: {default: false} | |||
| transparent: {default: false}, | |||
| generateEnvironment: {default: true} | |||
There was a problem hiding this comment.
Do we want the default to be true?
There was a problem hiding this comment.
I think it's pretty safe and not a huge performance hit as it only renders the once. It will even fix materials unexpectedly not looking right because they expect an environment map. So it's a nice feature, that you only need to type 'background` to get.
I'd even be tempted to take it a step further and make background="transparent:true" a default component on <a-scene> or at least add background to the hello-world boilerplate just to get the better behaviour by default.
src/components/scene/background.js
Outdated
| this.cubeCamera = cubeCamera; | ||
| this.needsEnvironmentUpdate = true; | ||
| scene.environment = cubeRenderTarget.texture; | ||
| this.el.sceneEl.addEventListener('loaded', function () { |
There was a problem hiding this comment.
I believe this event handler is not needed.
There was a problem hiding this comment.
I think you are right,
On a related note, do you know if there is an event handler for things like an object or image has finished loading asynchronously, which would allow this to still work nicely even if someone is loading their skybox etc without using <a-assets>?
There was a problem hiding this comment.
mmh not sure if there's a way to universally know it all assets have loaded if <a-assets> is not used. Components can do all sort of arbitrary stuff.
There was a problem hiding this comment.
I guess if someone wanted this behaviour they could do background.needsEnvironmentUpdate=true on this component from their custom components.
It might be nice if components like material would fire a bubbling event once they had loaded an image asynchronously so components like this can update the texture in a few common situations. Although this feature may be the carrot needed to get more developers to use <a-assets>
|
Nice job! It's pretty close. Just a few changes. This is going to be really useful. Some people got confused with models looking dark and we didn't have a quick solution to give them |
|
I think this now resolves the issues. |
|
that's done now :-) |
|
It looks great! Thanks so much! 🥇 |
|
Since Lighting Estimation has landed in Samsung Internet, I'm going to update this to handle lighting estimation by default. |
Description:
Adds behavior to
backgroundto allow it to set the environment property on the scene element.It automatically generates an environment map as a cube texture which can be overridden by setting the environment map on a per element basis.
No background:
Background is hotpink, no skybox
Background is still hot pink but with an image skybox