Skip to content

Show loading spinner when placing an order#68

Merged
candemiralp merged 6 commits into
adyen-examples:developfrom
JustinElst:add-loading-spinner-to-place-order
Nov 8, 2024
Merged

Show loading spinner when placing an order#68
candemiralp merged 6 commits into
adyen-examples:developfrom
JustinElst:add-loading-spinner-to-place-order

Conversation

@JustinElst

@JustinElst JustinElst commented Oct 30, 2024

Copy link
Copy Markdown
Contributor

Summary

When the placeOrder event is triggered, the plugin now displays a loading spinner to the shopper. Previously, there were no visual cues that signaled a process was taking place.

Tested scenarios

  • Happy/unhappy card payment flows with and without 3D Secure 2
  • Redirect Klarna payments with success and cancellation flows
  • Google Pay payments

@JustinElst JustinElst requested a review from a team as a code owner October 30, 2024 14:09
Comment thread view/frontend/templates/payment/model/adyen-payment-method.phtml Outdated
Comment thread view/frontend/templates/payment/model/adyen-payment-method.phtml Outdated
@candemiralp

Copy link
Copy Markdown
Contributor

Hello @JustinElst,

Thank you for your contribution. I've left a comment about an exception message that I got on my checkout. I've tried with 3DS2 and non 3DS2 card payments. Could you please elaborate on the issue?

Best Regards,
Can

@JustinElst

Copy link
Copy Markdown
Contributor Author

Thanks for your comments.
When a customer clicks the placeOrder button, a wire.placeOrder is triggered. This could take some time to in our case it does a round trip to the erp system to get a order-number. But in other cases with a slow internet or server this could take some time.

@candemiralp

candemiralp commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

FYI CODEOWNERS, the tests have been deployed locally and the PR has passed the tests successfully.

@candemiralp

Copy link
Copy Markdown
Contributor

Hello @JustinElst,

Thank you for your contribution and fixing the issues on the PR. This improvement will be released after completing the code reviews.

Best Regards,
Can

@candemiralp candemiralp merged commit 8f24302 into adyen-examples:develop Nov 8, 2024
@candemiralp candemiralp mentioned this pull request Nov 18, 2024
@sena1482 sena1482 changed the title Add visual loading.. spinner to place order Show loading spinner when processing the place order event Dec 10, 2024
@sena1482 sena1482 changed the title Show loading spinner when processing the place order event Show loading spinner when placing an order Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants