feat: disable place order button for adyen_cc#58
Merged
khushboo-singhvi merged 2 commits intoOct 3, 2024
Merged
Conversation
Disable button as default. Button gets enabled after all cc form fields are filled out correctly. Closes adyen-examples#55
candemiralp
approved these changes
Oct 3, 2024
khushboo-singhvi
approved these changes
Oct 3, 2024
Contributor
|
Hello @fzemmel, Thank you for your contribution. This PR has been merged and will be released on the next upcoming version. Best regards, |
This was referenced Oct 3, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable button as default. Button gets enabled after all cc form fields are filled out correctly.
Closes #55
Summary
When choosing cc as payment method the place order button should be disabled, until all cc form fields are filled correctly.
This PR changes method evaluateCompletion() in the Magewire CreditCard component to disable the button.
The button is enabled after all fields in the cc form are valid.
Tested scenarios
Tested on Magento 2.4.6-p7 with Hyvä Checkout 1.1.24 and Adyen Hyvä Module 1.0.0
Tested as guest and logged in customer
Tested only with Adyen Test Plattform
Fixed issue: #-55