-
Notifications
You must be signed in to change notification settings - Fork 303
Fix deprecated license specification format #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello Yuki, thanks for contributing again and fixing this warning! Is the second commit "Bump setuptools version" needed for the first one to work? If it's needed, we can merge it (in this case please merge both commit into one, with the explanation in the commit message). If it's not, let's avoid hardening dependencies requirements, as this can affect some users. |
|
Indeed PEP 639 support requires Setuptools 77. However, that's not a problem because users should upgrade to the latest version any way. From Installing Packages:
|
|
|
|
If Am I right that |
|
Thanks for the comments. I dropped the second commit. |
|
I'm not sure it must be dropped. Isn't |
|
Thanks for the answers @koyuki7w and @DimitriPapadopoulos. The first commit is good to go and useful, so I'll merge it right now. About the |
In the current version,
pip install .emits the following warnings:(These warnings can be seen by using
--logoption.)So fixed the way to specify the license as these warnings suggest. Also see https://peps.python.org/pep-0639/#deprecate-license-classifiers and https://peps.python.org/pep-0639/#deprecate-license-key-table-subkeys.