a lot of new sentences#88
Merged
icholy merged 3 commits intoadrianmo:masterfrom Jan 3, 2022
Merged
Conversation
Collaborator
Author
|
About errors. When parsing fails currently only first error is stored and all subsequent errors are discarded. I propose if maybe just wrapping them (or storing into slice or multierror) func (p *Parser) SetErr(context, value string) {
if p.err == nil {
p.err = fmt.Errorf("nmea: %s invalid %s: %s", p.Prefix(), context, value)
} else {
p.err = fmt.Errorf("nmea: %s invalid %s: %s, err: %w", p.Prefix(), context, value, p.err)
}
} |
Collaborator
|
This is awesome! Create a separate issue for the error discussion though. |
Collaborator
Author
|
added #89 |
icholy
reviewed
Jan 3, 2022
icholy
reviewed
Jan 3, 2022
icholy
approved these changes
Jan 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe
p.EnumString(could set special error type alaEnumValueErrorwhen it sees value that is not in list + instead of returning empty value we return that invalid value. In that case you could check forEnumValueErrorand ignore it if you want to and that invalid value would be still set to that sentence type so it is usable in that case.