Skip to content

Add MDA, MWD, MWV#81

Merged
adrianmo merged 4 commits intoadrianmo:masterfrom
Maescool:wi
Sep 8, 2021
Merged

Add MDA, MWD, MWV#81
adrianmo merged 4 commits intoadrianmo:masterfrom
Maescool:wi

Conversation

@Maescool
Copy link
Copy Markdown
Contributor

@Maescool Maescool commented Sep 4, 2021

For a project I'm receiving these sentence types.
Hope this looks okay, added tests and they work.

Comment thread mda.go Outdated
Copy link
Copy Markdown
Owner

@adrianmo adrianmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maescool thanks a lot for the contribution - you did an awesome job :)

Can you please have a look at the linter issues reported by the CI process? (I just fixed CI as it was broken so you couldn't have known before)

@adrianmo adrianmo added the kind/feature New feature label Sep 7, 2021
@Maescool
Copy link
Copy Markdown
Contributor Author

Maescool commented Sep 8, 2021

Fixed the linting, and removed the redundant empty check's

Copy link
Copy Markdown
Owner

@adrianmo adrianmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Waiting on the green light from @icholy :)

@adrianmo adrianmo merged commit 4de9528 into adrianmo:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants