-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Feat: Add support for horizontal orientation
to GridList
& ListBox
#8533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…to layout-orientation
@LFDanLu Would you be so kind to issue a build for this PR? I'm going insane because of a bug with virtualized dnd, which I can't seem to get rid of locally, even after reverting all changes and clearing caches. I would really like to know whether the issue exists on remote 😅 |
orientation
to ListLayout
delegateorientation
to GridList
& ListBox
@@ -117,6 +123,7 @@ export function useListBox<T>(props: AriaListBoxOptions<T>, state: ListState<T>, | |||
'aria-multiselectable': 'true' | |||
} : {}, { | |||
role: 'listbox', | |||
'aria-orientation': orientation === 'horizontal' ? orientation : undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@majornista Should we set aria-orientation
only if deviating from the implicit orientation as defined in each role spec? I adjusted useTabList
as well to match, let me know what you think 🙏
@nwidynski heya sorry about the delay, opened #8544 for your build |
@LFDanLu Thanks! I will take a look tmrw, otherwise this is ready for review if the team finds time 👍 |
sounds good, we are gearing up for a release very soon, but noted this one down (and #8523) for the team to checkout right after! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be bring this up with the team tomorrow, but looks good to me at a glance, thanks!
mainly wondering if some of the changes/refactors can be simplified since we already supported orientation for Listbox previously |
@LFDanLu Maybe the PR title is misleading - The primary target of this is to add |
b6452fc
to
2d97559
Compare
This PR adds support for
horizontal
orientations toListLayout
and affected components in preparation for aCarousel
contribution.✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: