fix: preventing Talkback erroneously focusing valid icon and adding similar support for MobileCombobox #8435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LFDanLu
commented
Jun 23, 2025
LFDanLu
commented
Jun 23, 2025
| @@ -98,7 +98,7 @@ export const TextFieldBase = forwardRef(function TextFieldBase(props: TextFieldB | |||
| let validId = useId(); | |||
| let validationIcon = isInvalid | |||
| ? <AlertMedium /> | |||
| : <CheckmarkMedium id={validId} aria-label={stringFormatter.format('valid')} />; | |||
| : <CheckmarkMedium id={validId} aria-hidden aria-label={stringFormatter.format('valid')} />; | |||
There was a problem hiding this comment.
Field will still announce valid due to the aria-describedBy, just preventing Talkback and NVDA from thinking the Checkmark should be focusable
|
Build successful! 🎉 |
snowystinger
previously approved these changes
Jun 23, 2025
5 tasks
|
Build successful! 🎉 |
reidbarber
approved these changes
Jun 24, 2025
devongovett
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From testing
✅ Pull Request Checklist:
📝 Test Instructions:
Test Combobox on mobile and make sure it is announced as "valid" when focused and
validationState="valid". Also test that TextField still announces "valid" when focused and is in the valid state🧢 Your Project:
RSP