Skip to content

fix(useDateFieldState): fix setValue to work when field is empty #8417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2025

Conversation

reidbarber
Copy link
Member

Fixes #4791

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Jun 18, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jun 19, 2025

Build successful! 🎉

snowystinger
snowystinger previously approved these changes Jun 19, 2025
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, you can still export the function ProgrammaticSetValueExampleRender, just include it in the exclude array in the meta default

@reidbarber
Copy link
Member Author

@snowystinger Thanks! Didn't realize that. Just updated.

@rspbot
Copy link

rspbot commented Jun 19, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jun 19, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jun 19, 2025

## API Changes

@react-aria/aria-modal-polyfill

/@react-aria/aria-modal-polyfill:watchModals

 watchModals {
   selector: string
-  undefined: {
-    document?: Document
-}
+  undefined: any
   returnVal: undefined
 }

@react-aria/live-announcer

/@react-aria/live-announcer:announce

 announce {
   message: Message
   assertiveness: Assertiveness
-  timeout: number
+  timeout: any
   returnVal: undefined
 }

@react-aria/overlays

/@react-aria/overlays:ariaHideOutside

 ariaHideOutside {
   targets: Array<Element>
-  root: Element
+  root: any
   returnVal: undefined
 }

@reidbarber reidbarber added this pull request to the merge queue Jun 20, 2025
Merged via the queue into main with commit 6503446 Jun 20, 2025
30 checks passed
@reidbarber reidbarber deleted the useDatePickerState-setvalue-commit-when-empty branch June 20, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useDateFieldState: setValue not correctly setting value for incomplete fields
4 participants