-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix(useDateFieldState): fix setValue to work when field is empty #8417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
reidbarber
merged 4 commits into
main
from
useDatePickerState-setvalue-commit-when-empty
Jun 20, 2025
Merged
fix(useDateFieldState): fix setValue to work when field is empty #8417
reidbarber
merged 4 commits into
main
from
useDatePickerState-setvalue-commit-when-empty
Jun 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build successful! 🎉 |
packages/@react-aria/datepicker/stories/useDatePicker.stories.tsx
Outdated
Show resolved
Hide resolved
Build successful! 🎉 |
snowystinger
previously approved these changes
Jun 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, you can still export the function ProgrammaticSetValueExampleRender
, just include it in the exclude
array in the meta default
@snowystinger Thanks! Didn't realize that. Just updated. |
Build successful! 🎉 |
LFDanLu
reviewed
Jun 19, 2025
Build successful! 🎉 |
## API Changes
@react-aria/aria-modal-polyfill/@react-aria/aria-modal-polyfill:watchModals watchModals {
selector: string
- undefined: {
- document?: Document
-}
+ undefined: any
returnVal: undefined
} @react-aria/live-announcer/@react-aria/live-announcer:announce announce {
message: Message
assertiveness: Assertiveness
- timeout: number
+ timeout: any
returnVal: undefined
} @react-aria/overlays/@react-aria/overlays:ariaHideOutside ariaHideOutside {
targets: Array<Element>
- root: Element
+ root: any
returnVal: undefined
} |
LFDanLu
approved these changes
Jun 19, 2025
snowystinger
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4791
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: