Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

logarytm
Copy link
Contributor

I've updated the Polish translation again - especially, I've added some missing phrases from Sprint 38.

@dangoor
Copy link
Contributor

dangoor commented Apr 21, 2014

@RaymondLim

@RaymondLim
Copy link
Contributor

@winek Thanks for your contribution with Polish translation. I know you did the translation last time, but this time you're changing the file structure from the original English file by adding all your new translation to the end of the file. This will create a maintenance issue in the future. Besides, it is harder to do comparison between two different versions. So can you please restore the file structure by moving each string that you added at the end to the actual line it is supposed to be? For example, "FILE" : "plik", should be on line 41.

Also I noticed that you have some strings that are no longer in the latest nls/root/strings.js file. Not sure which specific version you're referencing when you do your translation. I asked because you may have inaccurate translation if a string has been changed in a later English version. You need to delete lines between 470 (LANGUAGE_SYSTEM_DEFAULT) to 492 (LOCALE_HU) since these had been removed from English version. After removing these lines and restoring file structure, you should have the exact total line numbers as the English version. (ie. 541)

Once you've done can you also add the following comment at the end of your file? I'm assuming that you're translating for the latest SHA of nls/root/strings.js. You can read
localization readme
to see how to get the correct SHA of the referenced version of nls/root/strings.js.

/* Last translated for c3411bb7f686f98381b18e729c097b6c5e270694 */

@logarytm
Copy link
Contributor Author

Thank you for explanation, I'll correct things soon.

@njx
Copy link

njx commented May 14, 2014

Hi @winek - just following up on to check if you'll have time to work on this further. If you're busy, we can try to find someone else to update it. Thanks!

@njx
Copy link

njx commented May 14, 2014

Marking medium priority since this is a significant update.

@RaymondLim
Copy link
Contributor

Looks good. Merging now.

RaymondLim added a commit that referenced this pull request May 29, 2014
@RaymondLim RaymondLim merged commit ed2fa1a into adobe:master May 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants