Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

oslego
Copy link
Contributor

@oslego oslego commented Jun 4, 2013

Move color matching regex to new shared file in /utils/, used by InlineColorPicker and QuickView extensions.

Retry of the patch discussed in #3754.

Initial goal was to make InlineColorPicker match color names. Re-used existing regex found in QuickView/main.js which accomplished that goal.

@ghost ghost assigned RaymondLim Jun 4, 2013
@julianasuh
Copy link
Contributor

Open to @RaymondLim

@njx
Copy link

njx commented Jun 4, 2013

@oslego Hey Razvan - @RaymondLim is out this week; is it okay if this waits till next week to get merged? Thanks.

@oslego
Copy link
Contributor Author

oslego commented Jun 4, 2013

I'm ok to wait.

On Tuesday, June 4, 2013, Narciso Jaramillo wrote:

@oslego https://github.com/oslego Hey Razvan - @RaymondLimhttps://github.com/RaymondLimis out this week; is it okay if this waits till next week to get merged?
Thanks.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4079#issuecomment-18924445
.

@ghost ghost assigned redmunds Jun 5, 2013
@@ -0,0 +1,44 @@
/*
* Copyright (c) 2012 Adobe Systems Incorporated. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the year file was created, so change to 2013.

@redmunds
Copy link
Contributor

redmunds commented Jun 5, 2013

@oslego I can review this one. This looks pretty good. Just a couple small comments.

Also, you need to sign the CLA before I can merge your change.

@oslego
Copy link
Contributor Author

oslego commented Jun 6, 2013

Added changes per @redmunds's requests. I'm an Adobe employee, but I've signed the CLA nonetheless.

@redmunds
Copy link
Contributor

redmunds commented Jun 6, 2013

Yeah, even us Adobe employees need to sign it. Would be nice to be able to sign once for all Adobe open source projects. Anyway, are you sure you signed with this account: https://github.com/oslego ? It's not showing up for me.

@oslego
Copy link
Contributor Author

oslego commented Jun 6, 2013

I might have forgotten the username. I signed again using the credentials I've used to push the commits

@redmunds
Copy link
Contributor

redmunds commented Jun 6, 2013

Now I see it. Thanks. Merging.

redmunds added a commit that referenced this pull request Jun 6, 2013
Consolidate color matching regex and share across extensions
@redmunds redmunds merged commit 31b3db2 into adobe:master Jun 6, 2013
@oslego
Copy link
Contributor Author

oslego commented Jun 6, 2013

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants