-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Consolidate color matching regex and share across extensions #4079
Conversation
Open to @RaymondLim |
@oslego Hey Razvan - @RaymondLim is out this week; is it okay if this waits till next week to get merged? Thanks. |
I'm ok to wait. On Tuesday, June 4, 2013, Narciso Jaramillo wrote:
|
@@ -0,0 +1,44 @@ | |||
/* | |||
* Copyright (c) 2012 Adobe Systems Incorporated. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the year file was created, so change to 2013.
Added changes per @redmunds's requests. I'm an Adobe employee, but I've signed the CLA nonetheless. |
Yeah, even us Adobe employees need to sign it. Would be nice to be able to sign once for all Adobe open source projects. Anyway, are you sure you signed with this account: https://github.com/oslego ? It's not showing up for me. |
I might have forgotten the username. I signed again using the credentials I've used to push the commits |
Now I see it. Thanks. Merging. |
Consolidate color matching regex and share across extensions
Thank you! |
Move color matching regex to new shared file in
/utils/
, used by InlineColorPicker and QuickView extensions.Retry of the patch discussed in #3754.
Initial goal was to make InlineColorPicker match color names. Re-used existing regex found in
QuickView/main.js
which accomplished that goal.