Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Cryptic error message when addMenuItem() is passed bad args #3412

@peterflynn

Description

@peterflynn
  1. Install the BracketLESS extension
  2. Quit & relaunch Brackets

Result:
Console contains error "addMenuItem() -- error: 3 when adding command: bracketless.enabled" indicating an error code returned from brackets.app.addMenuItem().

Expected:
BracketLESS is doing something wrong here: passing a nonexistent command id as the relativeID arg. However, before the native menu migration we gave much more informative error strings. In this case it would have been "_getRelativeMenuItem(): MenuItem with Command id menu-view-sidebar not found in Menu view-menu". The message we actually show is uninformative and almost looks like brackets-shell bug rather then a problem with the extension's code.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions