-
Notifications
You must be signed in to change notification settings - Fork 606
Implement Windows Explorer "Open with..." option #296
Conversation
…nning Brackets instance
…ckets-from-windows-explorer
@jasonsanjose @peterflynn @gruehle can at least one of y'all please review this brackets-shell, Windows-only change too? Thanks! |
…tion. Will leave it to the installer to create
… remove on application uninstall)
Just submitted changes to the Windows installer scripts to have the installer create the Registry entries needed to associate the file types on application install. All ready for review now. @gruehle @jasonsanjose @ingorichter @couzteau @peterflynn Can someone please review? Thanks in advance! |
@gruehle pointed out that it looks like this pull request has the binary .msi files in it, which we don't want in the repo. We actually want them to go away from the git database entirely to keep the repo size small. There's no direct way to do that now that they're in this commit stream (even if you add a new commit removing them from this branch, if we later merge it as-is, the commit that added them will still be in the database, so the binaries will still be floating around in there). So, what we need to do is create a new branch with a squashed commit that doesn't have the binaries in them, then delete this branch. Eventually, git's GC will make the unreferenced commits go away. I think the easiest way to do that is:
|
@peterflynn logged a similar bug for a mistake I made adobe/brackets#4423 |
Oops. I did not mean to commit the .msi to that branch. Thanks for catching that, @JeffryBooher and @jasonsanjose . Also, thanks for the steps @njx to create the new branch. I've re-submitted this change as Pull Request #299. I'll close out and delete this branch as instructed. |
Overview
This change implements the Edge Code and Brackets user stories that allow Brackets to support the Windows Explorer "Open With..." command.
Please note that we still need an installer change to (1) pre-populate the necessary Registry entries prior to first launch; and (2) clean up the ProgID entries on Brackets uninstallation. However, even without these installer changes, the "Open With..." feature will still work, so long as you launch Brackets at least once before attempting to "open with..." a file.
Example Workflows
[note: Brackets Sprint 28 already supports opening a single file from the Brackets command-line. However, it always launches a new instance to open the given file.]
Implementation
This Windows-only, brackets-shell change adds two, new pieces of functionality:
For the first item, I've added a mutex to track when a Brackets instance is already running. Then, when a new file is opened from the command-line, the new instance will enumerate any already running instances of Brackets, starting with the top-most window instance (aka the most-recently used window), bring it to the front of the desktop windows, and send it the filename via a WM_COPYDATA message. Then, the second instance will immediately exit. Upon receipt of the WM_COPYDATA message, the receiving instance of Brackets will then call existing Javascript code to open the file and add it to the working set.
For the second item, I've added initialization code to create/update Registry entries corresponding to those associated with an application ProgID and individual Explorer FileExts entries in support of the "Open With..." command. This extra measure of initialization/update will help keep Brackets up-to-date, if for example you are running different builds of Brackets, without requiring that you uninstall and reinstall the application in order to continue using the "Open With..." command.