Fix laravel job attempts, when removing DLX #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…The value can mess things up. The attempts() method was designed to return the current attempt value, not the value of the previous run. Else the worker will try 1 try to long.
The attempts() method on the Job is/was interpreted wrong. the method mus return the previous_attempt + 1 = current attempt.
…sed. Previously this was handled by rabbitmq with a DLX. [removed]
- Added delayed messages with a higher priority when put back to the queue. - Added ability to reroute failed messages - Fixed when to acknowledge or decline messages. - Fixed attempts() when multiple delay values are used. - Fixed death worker loop, when queues are missing. - Fixed issue vyuldashev#305 - Fixed issue vyuldashev#302 - Fixed issue vyuldashev#301 - Fixed issue vyuldashev#299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.