cursor_x and cursor_y properties on Terminal #10442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terminal already has these values internally, this change exposes them to python.
My intention is to utilize these with a custom wrapper of Terminal class that adds support for ANSI color escapes. Having access to the cursor position makes it easy to know where in the TileGrid the colors need to get changed when an escape code is encountered.
If this overflows builds one option is try to make these available only if the tilepalettemapper module is enabled if that's possible. It's turned off for the tight builds. The two features aren't intrinsically linked, but I have no current intentions to use cursor position without tpm so it could save space and still allow my use-case.