Skip to content

Add Additional CPython Strict Module Name checks. #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2019
Merged

Add Additional CPython Strict Module Name checks. #72

merged 1 commit into from
Mar 3, 2019

Conversation

sommersoft
Copy link
Collaborator

Fixes #67.

This adds checks for ure vs re, ujson vs json, and uerrno vs errno. Combined them with the previous validator for ustruct.

@sommersoft sommersoft requested a review from kattni March 3, 2019 21:34
kattni
kattni approved these changes Mar 3, 2019
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks! 🌮

@kattni kattni merged commit 66aaa38 into adafruit:master Mar 3, 2019
@sommersoft sommersoft deleted the cpython_strict_modules branch March 15, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kattni kattni kattni approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sommersoft @kattni