Added type annotations #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
tekktrik
requested changes
Oct 6, 2022
|
Hi @tekktrik , Thank you for the comments! I have completed the changes. Thank you! |
tekktrik
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
Nice work! I've created adafruit/Adafruit_CircuitPython_Display_Text#175 as well.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 7, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_RA8875 to 3.1.16 from 3.1.15: > Merge pull request adafruit/Adafruit_CircuitPython_RA8875#30 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_SI5351 to 1.3.6 from 1.3.5: > Merge pull request adafruit/Adafruit_CircuitPython_SI5351#28 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L0X to 3.6.7 from 3.6.6: > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#36 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.7.9 from 0.7.8: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#52 from prcutler/issue50-morse-patterns Updating https://github.com/adafruit/Adafruit_CircuitPython_Simple_Text_Display to 1.2.10 from 1.2.9: > Merge pull request adafruit/Adafruit_CircuitPython_Simple_Text_Display#13 from isacben/add-type-annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR solves Missing Type Annotations #7
Please let me know if you have any comments.
I tested with Adafruit Feather RP2040 and the ST7789 display.
Thank you!