use a local test server instead of httpbin #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

FoamyGuy merged 2 commits into adafruit:main from FoamyGuy:local_test_server

Jun 2, 2025

Contributor

FoamyGuy commented May 31, 2025

Make our own little test server to run the test against instead of relying on 3rd party httpbin.


          use a local test server instead of httpbin

d08344e

FoamyGuy requested a review from justmobilize

May 31, 2025 15:12


          try 127.0.0.1

9a4ae29

Collaborator

justmobilize commented May 31, 2025

@FoamyGuy this looks great, do we also want to add the tests from files_test.py? They POST to https://httpbin.org/post just to make sure what we send and what CPython requests send are the same

Contributor Author

FoamyGuy commented Jun 2, 2025

@justmobilize yes that would be good. Ideally I think it's best to use a local server for anything that we can instead of remote httpbin.

I think it can come in a future PR though, this one doesn't need to wait on it.

I had a look in files_test.py and I'm not sure that I understand how it functions, like what mechanism populates values to the arguments being passed to the tests. I need to read a bit more about pytest.

justmobilize approved these changes

View reviewed changes

Collaborator

justmobilize commented Jun 2, 2025

Approved. I can also do the follow up for the other tests

FoamyGuy merged commit 2125597 into adafruit:main

1 check passed

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@f23c9c4)

8a9d7f4

Updating https://github.com/adafruit/Adafruit_CircuitPython_EK79686 to 2.0.1 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_EK79686#3 from FoamyGuy/displayio_api_updates

Updating https://github.com/adafruit/Adafruit_CircuitPython_FT5336 to 1.1.4 from 1.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_FT5336#8 from FoamyGuy/displayio_api_updates

Updating https://github.com/adafruit/Adafruit_CircuitPython_MONSTERM4SK to 1.0.5 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_MONSTERM4SK#20 from FoamyGuy/displayio_api_updates

Updating https://github.com/adafruit/Adafruit_CircuitPython_OV to 1.1.5 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_OV#24 from FoamyGuy/displayio_api_updates

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735 to 1.2.18 from 1.2.17:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735#24 from FoamyGuy/displayio_api_update

Updating https://github.com/adafruit/Adafruit_CircuitPython_STMPE610 to 1.3.18 from 1.3.17:
  > Merge pull request adafruit/Adafruit_CircuitPython_STMPE610#30 from FoamyGuy/displayio_api_update

Updating https://github.com/adafruit/Adafruit_CircuitPython_TSC2007 to 1.1.4 from 1.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_TSC2007#8 from FoamyGuy/displayio_api_updates

Updating https://github.com/adafruit/Adafruit_CircuitPython_CursorControl to 2.9.3 from 2.9.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#41 from FoamyGuy/displayio_api_update

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Button to 1.11.4 from 1.11.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#55 from FoamyGuy/displayio_api_update

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.10.3 from 2.10.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#83 from FoamyGuy/displayio_api_updates

Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.15.6 from 1.15.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#84 from FoamyGuy/displayio_api_update

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIO_UART to 1.1.2 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIO_UART#10 from adafruit/fix_docs_link

Updating https://github.com/adafruit/Adafruit_CircuitPython_Prompt_Toolkit to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Prompt_Toolkit#7 from adafruit/fix_docs_link

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 4.1.12 from 4.1.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#214 from FoamyGuy/local_test_server

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_PIO_UART, Adafruit_CircuitPython_Prompt_Toolkit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet