Added madctl parameter to ILI9341 driver for hardware rotation and RGB/BGR control, enabling faster rendering and more flexibility #43
+125
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritesh006
changed the title
ritesh006
force-pushed
the
feat/madctl-support
branch
4 times, most recently
from
1361b03 to
74a43af
Compare
|
Please review this commit |
|
reviewed. we will not merge, please use/add/adapt kwargs instead of hardcoding MADCTL writes |
ritesh006
force-pushed
the
feat/madctl-support
branch
from
74a43af to
a289fba
Compare
|
Hi @ladyada your review comment addressed please take a look. |
ritesh006
force-pushed
the
feat/madctl-support
branch
from
a289fba to
c49a3cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for passing a
madctlparameter to theILI9341driver, allowing developers to directly control hardware rotation via the MADCTL register.It also preserves support for BGR/RGB selection and inversion.
Motivation
Currently, display rotation relies on displayio’s software-based handling, which can be inefficient.
By exposing MADCTL, developers can take advantage of the LCD controller’s built-in rotation logic, which improves performance (especially for OnDiskBitmaps).
Changes
madctlparameter to theILI9341constructor.bgrandinvertoptions.madctl.Tests
test_madctl.py) covering:Related Issues
Closes #26 ("Make it easy to set MADCTL for rotation").