add headers and status_code to response #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This resolves: adafruit/Adafruit_CircuitPython_PortalBase#58 |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 29, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.14.0 from 2.13.6: > Merge pull request adafruit/Adafruit_CircuitPython_EPD#92 from adafruit/quad_color Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.11.4 from 3.11.3: > Merge pull request adafruit/Adafruit_CircuitPython_GPS#117 from adafruit/TheKitty-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_FakeRequests to 1.1.0 from 1.0.18: > Merge pull request adafruit/Adafruit_CircuitPython_FakeRequests#10 from FoamyGuy/headers_and_status Updating https://github.com/adafruit/Adafruit_CircuitPython_FruitJam to 0.5.0 from 0.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_FruitJam#6 from FoamyGuy/more_portalbase_stuff Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 1.3.5 from 1.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#78 from FoamyGuy/update_frequency Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 3.2.1 from 3.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#112 from FoamyGuy/property_fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are necessary in order for Fake_Request to work with current version of portalbase because it tries to access both
response.headersandresposne.status_codeinside ofcheck_response()https://github.com/adafruit/Adafruit_CircuitPython_PortalBase/blob/main/adafruit_portalbase/network.py#L581Also added parameter docstrings for new and existing args.