Improvement suggestions

src/ffi.rs

@@ -1,3 +1,4 @@
+#![allow(non_camel_case_types)]
 use std::ffi::c_char;
 
 #[repr(C)]

src/lib.rs

@@ -575,28 +575,51 @@ mod test {
             ("http://example.com/", "http://example.com/"),
             ("HTTP://EXAMPLE.COM", "http://example.com/"),
             ("http://user:[email protected]", "http://user:[email protected]/"),
+            (
+                "HTTP://EXAMPLE.COM/FOO/BAR?K1=V1&K2=V2",
+                "http://example.com/FOO/BAR?K1=V1&K2=V2",
+            ),
+            (
+                "http://example.com/🦀/❤️/",
+                "http://example.com/%F0%9F%A6%80/%E2%9D%A4%EF%B8%8F/",
+            ),
+            (
+                "https://example.org/hello world.html",
+                "https://example.org/hello%20world.html",
+            ),
+            (
+                "https://三十六計.org/走為上策/",
+                "https://xn--ehq95fdxbx86i.org/%E8%B5%B0%E7%82%BA%E4%B8%8A%E7%AD%96/", // weird, but this binding lib cannot change the implementation
+            ),
         ];
         for (value, expected) in tests {
+            eprintln!("{value} -> {expected}");
             let url = Url::parse(value, None).expect("Should have parsed url");
-            assert_eq!(format!("{}", url), expected);
             assert_eq!(url.to_string(), expected);
         }
     }
 
     #[test]
-    fn should_parse_with_try_from() {
-        let tests = [("http://example.com/", true), ("invalid url", false)];
-        for (value, should_parse) in tests {
-            let url = Url::parse("http://example.com/", None).unwrap();
-            let parsed = Url::try_from(value);
-            if should_parse {
-                assert_eq!(parsed.is_ok(), should_parse);
-                assert_eq!(url, parsed.unwrap());
-            } else {
-                assert!(parsed.is_err());
-            }
-        }
+    fn try_from_ok() {
+        let url = Url::try_from("http://example.com/foo/bar?k1=v1&k2=v2");
+        dbg!(&url);
+        let url = url.unwrap();
+        assert_eq!(url.href(), "http://example.com/foo/bar?k1=v1&k2=v2");
+        assert_eq!(
+            url,
+            Url::parse("http://example.com/foo/bar?k1=v1&k2=v2", None).unwrap(),
+        );
     }
+
+    #[test]
+    fn try_from_err() {
+        let url = Url::try_from("this is not a url");
+        dbg!(&url);
+        let error = url.unwrap_err();
+        assert_eq!(error.to_string(), r#"Invalid url: "this is not a url""#);
+        assert!(matches!(error, Error::ParseUrl(_)));
+    }
+
     #[test]
     fn should_compare_urls() {
         let tests = [