Make ada-rust compile for wasm32-wasi and -unknown #23
Conversation
|
|
|
@anonrig Thank you so much for your quick response / review! This one is really nice as we'd like to include ada-url into our existing Rust crate that is compiled to wasm32-unknown-unknown. |
Happy to help! You should also know that the ada repository also supports webassembly by default. |
|
Oh yea, I have seen that but it only compiles to wasm32-unknown-emscripten AFAIK and that unfortunately can't be included into a Rust crate that is built with wasm-bindgen to wasm32-unknown-unknown. Or did I miss something? |
You're probably right. |
|
@RReverser Would you mind also updating readme and mention that webassembly is supported? |
|
Not at all. I just need to do the CI thing first - it's a bit involved. |
RReverser
force-pushed
the
main
branch
2 times, most recently
from
d9a5d3d to
9206d00
Compare
|
CI integration for wasm32-wasi is done, can be seen running tests via Wasmtime here: https://github.com/RReverser/ada-rust-wasm/actions/runs/5930243141/job/16079561574
Now that I looked, I'm actually not sure where would be appropriate place to add it. README currently doesn't mentioned supported or explicitly unsupported platforms, so I'm not sure if it's worth calling out Wasm specifically and how. |
|
I've updated main with Ada v2.6.1. Can you rebase? |
This adds ability to compile for wasm32-wasi and wasm32-unknown-unknown targets. Both of those use WASI SDK for compilation and add necessary flags for linking C++ library. WASI SDK is a bit more straightforward, while wasm32-unknown-unknown requires a few hacks to get a pure Wasm output w/o any imports, but it works too. While changing flags in build.rs, also leveraged some new `cc` options and made it possible to compile on Windows via Clang instead of MSVC if user chooses to do so.
Already included in the check job.
|
Done. |
|
Could we get a new version released of this crate? |
Looks like already out: https://crates.io/crates/ada-url |
|
Oh ups. Never mind. Thanks a ton 🙏 |
This adds ability to compile for wasm32-wasi and wasm32-unknown-unknown targets.
Both of those use WASI SDK for compilation and add necessary flags for linking C++ library. wasm32-wasi is a bit more straightforward, while wasm32-unknown-unknown requires a few hacks to get a pure Wasm output w/o any imports, but at least it can work too. Demo:
While changing flags in build.rs, also leveraged some new
ccoptions and made it possible to compile on Windows via Clang instead of MSVC if user chooses to do so.