Feature `libcpp` doesn't compile

[KSXGitHub]

Steps to reproduce

cargo test --features=libcpp

Expected behavior

It compiles and runs test successfully.

Actual behavior

warning: In file included from ./deps/ada.cpp:3:
warning: ./deps/ada.h:20:10: fatal error: 'string' file not found
warning: #include <string>
warning:          ^~~~~~~~
warning: 1 error generated.

[anonrig]

It works on my local machine. macos 13.4. @lemire any idea?

➜  ada-rust git:(no-std) cargo test --features=libcpp
   Compiling ada-url v1.4.3 (/Users/yagiz/Developer/ada-rust)
    Finished test [unoptimized + debuginfo] target(s) in 1.44s
     Running unittests src/lib.rs (target/debug/deps/ada_url-43f0619448966089)

running 10 tests
test idna::tests::unicode_should_work ... ok
test test::should_order_alphabetically ... ok
test test::can_parse_simple_url ... ok
test test::should_clone ... ok
test test::should_compare_urls ... ok
test test::try_from_err ... ok
test idna::tests::ascii_should_work ... ok
test test::should_parse_simple_url ... ok
test test::should_display_serialization ... ok
test test::try_from_ok ... ok

test result: ok. 10 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests ada-url

running 24 tests
test src/idna.rs - idna::Idna::unicode (line 14) ... ok
test src/idna.rs - idna::Idna::ascii (line 31) ... ok
test src/lib.rs - Url::hostname (line 452) ... ok
test src/lib.rs - Url::can_parse (line 202) ... ok
test src/lib.rs - Url::pathname (line 486) ... ok
test src/lib.rs - Url::password (line 304) ... ok
test src/lib.rs - Url::host (line 414) ... ok
test src/lib.rs - Url::origin (line 231) ... ok
test src/lib.rs - Url::parse (line 169) ... ok
test src/lib.rs - Url::hash (line 383) ... ok
test src/lib.rs - Url::set_hash (line 396) ... ok
test src/lib.rs - Url::set_hostname (line 464) ... ok
test src/lib.rs - Url::set_port (line 353) ... ok
test src/lib.rs - Url::port (line 338) ... ok
test src/lib.rs - Url::search (line 520) ... ok
test src/lib.rs - Url::set_href (line 254) ... ok
test src/lib.rs - Url::set_password (line 316) ... ok
test src/lib.rs - Url::set_host (line 426) ... ok
test src/lib.rs - Url::protocol (line 555) ... ok
test src/lib.rs - Url::set_pathname (line 498) ... ok
test src/lib.rs - Url::set_username (line 282) ... ok
test src/lib.rs - Url::username (line 270) ... ok
test src/lib.rs - Url::set_protocol (line 567) ... ok
test src/lib.rs - Url::set_search (line 535) ... ok

test result: ok. 24 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.52s

[KSXGitHub]

I think it's probably because I don't have the necessary packages or libraries.

If you can setup a minimal docker or podman container that successfully compiles this, we will know what is missing.

[lemire]

@anonrig @KSXGitHub

I strongly suspect that this is an invalid issue.

@KSXGitHub should check that they can compile C++ code (outside this project) with libc++ on their system. It is uncommon to build C++ with libc++ under Linux. The libc++ runtime is mostly used under macOS and FreeBSD (and other BSDs) but not so much under Linux.

My suspicion is that their Linux environnement does not support compiling against libc++ either because libc++ is not installed, or because it is not properly configured.

[lemire]

I have marked the issue as invalid. @KSXGitHub should provide evidence that the issue appears on systems where libc++ is properly configured.

[KSXGitHub]

@lemire It does compile correctly once I install libc++. But this doesn't mean ada-url will have nothing to do: The error message is vague, the documentation is lacking. If you did not mention libc++, I wouldn't know what it is.

[anonrig]

You're right about the documentation. We need to add this to readme as same as you did with std