Skip to content

fix(logging): add missing process_type ostream operator<< #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

fix(logging): add missing process_type ostream operator<< #972

merged 1 commit into from
Jul 7, 2025

Conversation

watilde
Copy link
Contributor

@watilde watilde commented Jul 6, 2025

This PR adds a required operator<< overload for the process_type enum, which is necessary for logging with ada_log. If there is a more appropriate or recommended way to handle this, please let me know!

Steps to reproduce:

cmake -B build -DADA_TESTING=ON
cmake --build build 
ADA_LOGGING=1 ctest --output-on-failure --test-dir build

@lemire lemire merged commit 77ff26a into ada-url:main Jul 7, 2025
47 checks passed
@watilde watilde deleted the fix/ada-log branch July 7, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemire lemire lemire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@watilde @lemire