for maximal portability, use only ASCII #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
approved these changes
Mar 1, 2025
tests/wpt/setters_tests.json
Outdated
| @@ -110,7 +110,7 @@ | |||
| } | |||
| }, | |||
| { | |||
| "comment": "Can’t switch from URL containing username/password/port to file", | |||
| "comment": "Can't switch from URL containing username/password/port to file", | |||
There was a problem hiding this comment.
We shouldn't change this file. If we do, the next WPT updater script will override it.
|
@anonrig Should be good now. All of our code should be ASCII. We need to do more to promote UTF-8 as the default in C++. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2025, everyone should have adopted Unicode and UTF-8 ought to be the standard.
It is perfectly fine to use UTF-8 in C++ in such cases.
Unfortunately, there are many legacy systems.
For maximal support, adopting ASCII is the only safe path.