Reset processedCount when downloading all artifacts#889
Merged
konradpabjan merged 1 commit intoactions:mainfrom Nov 29, 2021
Merged
Reset processedCount when downloading all artifacts#889konradpabjan merged 1 commit intoactions:mainfrom
konradpabjan merged 1 commit intoactions:mainfrom
Conversation
Contributor
|
@konradpabjan could you take a look when you get a chance since you have context on this code? |
Contributor
|
Also looks like we need to do another |
konradpabjan
approved these changes
Nov 29, 2021
|
No tests? 😮 |
Contributor
|
The changes here are relatively simple so it doesn't hurt though I'm running some extra tests locally to confirm behavior. There are a lot of tests for other parts of the upload/download process but the status reporter is something that is currently lacking https://github.com/actions/toolkit/tree/main/packages/artifact/__tests__ |
at-wat
pushed a commit
to at-wat/actions-toolkit
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
totalNumberOfFilesToProcesswas reset for each artifact but not theprocessedCountwhich lead to percentage values higher than 100% when downloading all artifacts. Also resetting theprocessedCountto0fixes that and scopes the counts to a single artifact.Fixes actions/download-artifact#95
Here is another output with > 100% percent in log output https://github.com/campersau/CefSharp/runs/3389459433?check_suite_focus=true#step:2:3. There are two artifacts with 4 files each: