Support multiple versions in single invocation

[Xlient]

Description:
Adds support to install multiple versions of .NET with a single invocation. Specified using a multiline string
Example :

- uses: actions/checkout@v2
- uses: actions/setup-dotnet@v1
  with:
    dotnet-version: |
       3.1.x
       5.0.x
- run: dotnet build <my project>

Related issue:
fixes #146

Check list:

• Mark if documentation changes are required.
• Mark if tests were added or updated to cover the changes.

[GGG-KILLER]

I believe it would be better if this used YAML arrays instead of a comma separated string.

Given that YAML has builtin support for arrays, it is a bit counterintuitive to use a comma-separated string instead of YAML arrays imo.

[Xlient]

I believe it would be better if this used YAML arrays instead of a comma separated string

Hello@GGG-KILLER, while I agree it would be more ideal to use an array, I don't believe the actions toolkit supports getting input as an array of strings with the YAML syntax.

[GGG-KILLER]

I believe it would be better if this used YAML arrays instead of a comma separated string

Hello@GGG-KILLER, while I agree it would be more ideal to use an array, I don't believe the actions toolkit supports getting input as an array of strings with the YAML syntax.

True, after checking the other setup-* actions, it seems the standard method of testing against multiple versions is to use matrix builds.

Found another action that accepts multiple inputs and comma separated seems to be standard practice.

[GGG-KILLER]

Just my 2 cents, but wouldn't it be better to just have a single dotnet-version input and use getMultilineInput on that?

I feel like having two differently named options for the same thing (one accepting a single input and the other accepting multiple) is a bit counter intuitive.

Also, on another note, the multiple version test and README are still using dotnet-version instead of dotnet-versions

[Xlient]

Also, on another note, the multiple version test and README are still using dotnet-version instead of dotnet-versions

Thanks for catching that 👍🏾

[vsafonkin]

Hi @Xlient, maybe it will be better to create dotnetInstaller object for each dotnet version? In this case we should change nothing in installer.ts logic. I mean something like this:

if (versions) {
      const includePrerelease: boolean =
        (core.getInput('include-prerelease') || 'false').toLowerCase() === 'true';

      let dotnetInstaller: installer.DotnetCoreInstaller;
      for (const version of versions) {
          dotnetInstaller = new installer.DotnetCoreInstaller(
              version,
              includePrerelease
          );
          await dotnetInstaller.installDotnet();
      }
}

[Xlient]

Hello @vsafonkin, I've updated setup-dotnet.ts and tests to reflect your suggested refactorings

[vsafonkin]

@Xlient, great, thank you!

[MaksimZhukov]

I think we should change a bit the action.yml and README:

description: 'Optional SDK version to use. If not provided, will install global.json version when available. Examples: 2.2.104, 3.1, 3.1.x'

-->

description: 'Optional SDK version(s) to use. If not provided, will install global.json version when available. Examples: 2.2.104, 3.1, 3.1.x'

and

optionally downloading and caching a version of dotnet by SDK version and adding to PATH

-->

optionally downloading and caching version(s) of dotnet by SDK version(s) and adding to PATH

[GGG-KILLER]

optionally downloading and caching a version of dotnet by SDK version and adding to PATH

-->

optionally downloading and caching version(s) of dotnet by SDK version(s) and adding to PATH

Maybe the caching part should be removed as well? Seems like it hasn't been working since v1.7.0 (see #141)

[RehanSaeed]

How does this work in conjunction with global.json?

I currently use global.json to install a current version and separately install older versions by hardcoding a version.

[vsafonkin]

Hi @RehanSaeed, if you have dotnet-version input in your workflow with multiple versions, only these versions will be installed. The version from global.json will be installed if the dotnet-version input is empty. In your case, I suppose, you can use following:

- name: Setup dotnet
  uses: actions/setup-dotnet@v1.9.0
          
- name: Setup dotnet
  uses: actions/setup-dotnet@v1.9.0
    with:
      dotnet-version: |
        5.0.x
        6.0.x

It installs version from global.json and other required versions from the second invocation of action.