Skip to content

fix: replace - with _ #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2025
Merged

fix: replace - with _ #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ba6c13
fix: replace `-` with `_`
Omochice May 3, 2025
41b96c9
test: update snapshots
Omochice May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/get-permissions-from-inputs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ export function getPermissionsFromInputs(env) {
if (!key.startsWith("INPUT_PERMISSION-")) return permissions;
if (!value) return permissions;

const permission = key.slice("INPUT_PERMISSION-".length).toLowerCase();
const permission = key.slice("INPUT_PERMISSION-".length).toLowerCase()
.replaceAll(/-/g, "_");

// Inherit app permissions if no permissions inputs are set
if (permissions === undefined) {
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/index.js.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ Generated by [AVA](https://avajs.dev).
--- REQUESTS ---␊
GET /repos/actions/create-github-app-token/installation␊
POST /app/installations/123456/access_tokens␊
{"repositories":["create-github-app-token"],"permissions":{"issues":"write","pull-requests":"read"}}`
{"repositories":["create-github-app-token"],"permissions":{"issues":"write","pull_requests":"read"}}`

## post-revoke-token-fail-response.test.js

Expand Down
Binary file modified tests/snapshots/index.js.snap
View file
Open in desktop
Binary file not shown.