-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Create test-ubuntu-git Docker Container for Proxy Tests
#1616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| # Use `docker/metadata-action` to preserve tags and labels that exist on the GHCR.io container image. | ||
| # - name: Extract metadata (tags, labels) for Docker | ||
| # id: meta | ||
| # uses: docker/[email protected] | ||
| # with: | ||
| # images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced this block is necessary at this point. I'd like to see what happens without it first.
test-ubuntu-gittest-ubuntu-git Docker Container for Proxy Tests
| uses: docker/[email protected] | ||
| with: | ||
| registry: ${{ env.REGISTRY }} | ||
| username: ${{ github.actor }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is ${{ github.actor }} always the actions org?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github.repository_owner is another option, but I wanted to try it this way first and see if it works OK.
I figure it should help make auth-related failures in the workflow more clear. (e.g. joe triggered the workflow, but joe doesn't have the requisite permissions).
It might also be handy to see who published the image in GHCR.io in the event we need to do some forensics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see other workflows in the actions org that also use github.actor when pushing to ghcr.io including actions/runner.
fhammerl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The
test-proxyCI check has been failing since December 19, 2023.test-proxydepends on Docker Hub container imagealpine/git:latest.It seems a recent update to
alpine/gitcaused this test to start failing.This PR seeks to establish a new git-enabled Linux container image hosted in the GitHub Container Image registry (ghcr.io). A subsequent PR will update
test-proxyto utilize this new image.By establishing a container image that is defined, maintained, published, and versioned via the
actions/checkoutrepo, we insulateactions/checkoutCI from external factors that introduce breaking changes.