Skip to content

Document that filter doesn't override fetch-depth#1505

Open
jakebailey wants to merge 1 commit into
actions:mainfrom
jakebailey:filter-docs
Open

Document that filter doesn't override fetch-depth#1505
jakebailey wants to merge 1 commit into
actions:mainfrom
jakebailey:filter-docs

Conversation

@jakebailey

Copy link
Copy Markdown

As noted in #1396 (comment), if you want to make full use of filter: blob:none, you still need to set fetch-depth: 0, as the default is still 1 which means you still don't get any history.

Happy to change this to whatever makes sense.

@jakebailey jakebailey requested a review from a team as a code owner October 5, 2023 16:05
@jenseng

jenseng commented Oct 24, 2023

Copy link
Copy Markdown

Or perhaps if a filter is set, fetch-depth could then implicitly default to 0? I can't think of a scenario where you'd want a simultaneously shallow AND partial clone.

edit: fixed 1 -> 0 😆

@jakebailey

Copy link
Copy Markdown
Author

I assume you mean "default to 0", but yeah, that was something I thought about too, I just wasn't sure how much of a breaking change was palatable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants