-
Notifications
You must be signed in to change notification settings - Fork 693
Add support for creating artifact metadata storage records #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for creating artifact metadata storage records when attestations are pushed to OCI registries. The feature is controlled by a new create-storage-record input parameter that defaults to true and requires the artifact-metadata:write permission.
- Adds a new
create-storage-recordinput field to control artifact metadata storage record creation - Updates the Actions version from v3.0.0 to v3.1.0
- Documents the new
artifact-metadata:writepermission requirement
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Bumps package version from 2.0.0 to 3.1.0 to reflect the new feature |
| action.yml | Adds the new create-storage-record input parameter and updates the actions/attest dependency to v3.1.0 |
| README.md | Documents the new permission requirement and the create-storage-record configuration option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Requires that push-to-registry is set to true. | ||
| # Requires that the "subject-name" parameter specify the fully-qualified | ||
| # image name. Defaults to true. |
Copilot
AI
Dec 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation states that create-storage-record requires subject-name to specify a fully-qualified image name, but this requirement is not mentioned in the action.yml description or the PR description. Consider either adding this constraint to the action.yml description for consistency, or removing it from the README if it's not actually enforced.
bdehamer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can ditch the package.json changes.
Signed-off-by: Meredith Lancaster <[email protected]>
This adds a new boolean
create-storage-recordfield that when set totrue, will create an artifact metadata storage record when thepush-to-registryfield is also set to true. If thepush-to-registryfield is set tofalse, a storage record will not be created.Because creating storage records requires the
artifact-metadata:writepermission, the Action will not create a record if the permission is not provided and continue operations gracefully.