Skip to content

Conversation

@malancas
Copy link
Contributor

@malancas malancas commented Dec 18, 2025

This adds a new boolean create-storage-record field that when set to true, will create an artifact metadata storage record when the push-to-registry field is also set to true. If the push-to-registry field is set to false, a storage record will not be created.

Because creating storage records requires the artifact-metadata:write permission, the Action will not create a record if the permission is not provided and continue operations gracefully.

@malancas malancas changed the title Support storage record creation Add support for creating artifact metadata storage records Dec 18, 2025
@malancas malancas marked this pull request as ready for review December 18, 2025 21:05
@malancas malancas requested a review from a team as a code owner December 18, 2025 21:05
Copilot AI review requested due to automatic review settings December 18, 2025 21:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for creating artifact metadata storage records when attestations are pushed to OCI registries. The feature is controlled by a new create-storage-record input parameter that defaults to true and requires the artifact-metadata:write permission.

  • Adds a new create-storage-record input field to control artifact metadata storage record creation
  • Updates the Actions version from v3.0.0 to v3.1.0
  • Documents the new artifact-metadata:write permission requirement

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
package.json Bumps package version from 2.0.0 to 3.1.0 to reflect the new feature
action.yml Adds the new create-storage-record input parameter and updates the actions/attest dependency to v3.1.0
README.md Documents the new permission requirement and the create-storage-record configuration option

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +103 to +105
# Requires that push-to-registry is set to true.
# Requires that the "subject-name" parameter specify the fully-qualified
# image name. Defaults to true.
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation states that create-storage-record requires subject-name to specify a fully-qualified image name, but this requirement is not mentioned in the action.yml description or the PR description. Consider either adding this constraint to the action.yml description for consistency, or removing it from the README if it's not actually enforced.

Copilot uses AI. Check for mistakes.
tingx2wang
tingx2wang previously approved these changes Dec 18, 2025
Copy link
Collaborator

@bdehamer bdehamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can ditch the package.json changes.

Signed-off-by: Meredith Lancaster <[email protected]>
@malancas malancas merged commit 00014ed into main Dec 19, 2025
5 checks passed
@malancas malancas deleted the support-storage-record-creation branch December 19, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants