Skip to content

Reflect #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Reflect #3

merged 3 commits into from
Jun 5, 2023

Conversation

qicz
Copy link
Member

@qicz qicz commented Jun 5, 2023

  • With pull requests:
    • Open your pull request against main
    • Your pull request should have no more than two commits, if not you should squash them.
    • You should pass all tests by go test -v ./... at the project root path in local.
    • It should pass all tests in the available continuous integration systems such as GitHub Actions.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

Fixes: #2

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@qicz qicz merged commit 8ff514f into acmestack:main Jun 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

easy convert
1 participant