Skip to content

Conversation

@neilpang
Copy link
Member

sync

hostup and others added 30 commits December 1, 2025 13:33
bug fix Omnios fial
This updates the Exoscale DNS script to work with v2 of their API.
…validation check against the omg.lol API to confirm address and apikey are good before proceeding
fix: update Exoscale DNS script
Make it more resistant to deploy hooks api change by passing custom arguments first
handle the case of metadata 404 in old api domains

fix index of domain start

fix shfmt

Revert "handle the case of metadata 404 in old api domains"

This reverts commit 9fe4616.

fix 404 on dot ad hyphen

fix shfmt
tomo2403 and others added 28 commits December 27, 2025 11:02
- Prefer using a pipe to `while read`
- But use a temp file when the loop needs to modify variables that need to be used outside the loop, as the pipe creates a subshell and modifications do not survive after the loop exits.
The config file checks were returning okay even when there were errors. The yq tool returns "null" when it cannot find what's queried, but exists with a 0 rc still.
Before this, checker issues were only logged. This stops the deployment if any configuration is incorrect.
acme.sh takes care of that
Because it causes a mysterious crash and it's honestly not worth it.
Before this, the eval call would try to run some commands (if they were compound commands) in the yaml file on the machine running acme.sh

Eval might not be worth it for the little benefit it brings.
Before this, some deployment scripts would interact with STDIN and that would cause this loop to skip some elements. By using descriptor 3 we avoid clashing with the very common stdin and stdout.
kislyuk yq (used by Debian packages) does not accept `yq e` and
also returns strings with double quotes.

mikefarah's yq-go (used by Alpine) accepts `yq e` and `yq`.

replace `yq e` with `yq` and also use `-r` switch to remove double
quoting to ensure uniform return values from both yq versions.

Signed-off-by: invario <[email protected]>
Multideploy: Deploy to multiple hooks of the same type
change default renew to 30 days
and fix readme
@github-actions
Copy link

Welcome
READ ME !!!!!
Read me !!!!!!
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please read the DNS API Dev Guide.
You MUST pass the DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@neilpang neilpang merged commit 3ae9711 into master Dec 27, 2025
26 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.