-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
QUIC.cloud DNS API support (dns_api.sh) #6631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Welcome |
|
You MUST pass the DNS-API-Test. |
|
Hi, |
|
Now after 1 hour 45 minutes: ...and it passes so much first! Bob |
|
Can someone let me know if I'm wrong in believing that I've gone about as far in testing as I can go? Or is it expected that all tests will pass, each and every time if everything is right? Thanks! Bob |
|
Now it's failing in FreeBSD, but it passed there earlier. So much is passing and the reasons for failing don't seem like DNS API bugs to me... |
|
Run succeeded. |
|
I really think it's ready to be approved. The workflow succeeded. Is there something I still need to do? |
|
@adriangligor |
| dns_qc_add() { | ||
| fulldomain=$1 | ||
| txtvalue=$2 | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check "if ! _exists jq " _err ""; and return 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neilpang I'm a little confused. Do you want me to verify that fulldomain and/or txtvalue are not JSON? Or that the response is JSON (perhaps right before line 106?).
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 26 in 37cf431
| if ! _exists jq; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neilpang Thanks for the explanation. I've pushed the update
|
it's not passing. https://github.com/rperper/acme.sh/actions/runs/20462958239/job/58799751194 you need to change the dockerfile to add jq. |
QUIC.cloud
This is support for acme.sh for the QUIC.cloud network.