Skip to content

Conversation

@rperper
Copy link

@rperper rperper commented Nov 20, 2025

QUIC.cloud

This is support for acme.sh for the QUIC.cloud network.

@github-actions
Copy link

Welcome
READ ME !!!!!
Read me !!!!!!
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please read the DNS API Dev Guide.
You MUST pass the DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@neilpang
Copy link
Member

You MUST pass the DNS-API-Test.
You MUST pass the DNS-API-Test.
You MUST pass the DNS-API-Test.
You MUST pass the DNS-API-Test.
You MUST pass the DNS-API-Test.
You MUST pass the DNS-API-Test.

@rperper
Copy link
Author

rperper commented Dec 9, 2025

Hi,
The pull request check failed in Solaris with:

 => Fetching CSWlibexpat1-2.7.2,REV=2025.09.21 (10/36) ...
  --2025-12-08 17:57:19--  http://mirror.opencsw.org/opencsw/testing/i386/5.11/libexpat1-2.7.2,REV=2025.09.21-SunOS5.10-i386-CSW.pkg.gz
  Resolving mirror.opencsw.org (mirror.opencsw.org)... 131.188.40.82, 2001:638:a000:4140::ffff:82
  Connecting to mirror.opencsw.org (mirror.opencsw.org)|131.188.40.82|:80... connected.
  HTTP request sent, awaiting response... 404 Not Found
  2025-12-08 17:57:19 ERROR 404: Not Found.
  
  
  Fetching of CSWlibexpat1-2.7.2,REV=2025.09.21 failed. Try updating your catalog with pkgutil -U.
  Error: The process '/usr/bin/bash' failed with exit code 1```
This appears to be an issue with the Solaris test, not the code, or am I misreading it?
Thanks,

Bob

@rperper
Copy link
Author

rperper commented Dec 9, 2025

Now after 1 hour 45 minutes:
This looks like an availability error:

#6 1440.4 Errors during downloading metadata for repository 'updates-x86_64':
#6 1440.4   - Curl error (28): Timeout was reached for https://www.mageia.org/mirrorlist/?release=9&arch=x86_64&section=core&repo=updates [Connection timeout after ***00 ms]
#6 1440.4   - Curl error (28): Timeout was reached for https://www.mageia.org/mirrorlist/?release=9&arch=x86_64&section=core&repo=updates [Failed to connect to www.mageia.org port 443 after ***00 ms: Timeout was reached]
#6 1440.4 Error: Failed to download metadata for repo 'updates-x86_64': Cannot prepare internal mirrorlist: Curl error (28): Timeout was reached for https://www.mageia.org/mirrorlist/?release=9&arch=x86_64&section=core&repo=updates [Failed to connect to www.mageia.org port 443 after ***00 ms: Timeout was reached]
#6 1440.4 Ignoring repositories: mageia-x86_64, updates-x86_64
#6 1440.4 No match for argument: openssl
#6 1440.4 No match for argument: socat
#6 1440.4 No match for argument: idn
#6 1440.4 Package curl-1:7.88.1-4.8.mga9.x86_64 is already installed.
#6 1440.4 No match for argument: wget
#6 1440.4 Error: Unable to find a match: openssl socat idn wget
#6 ERROR: process "/bin/sh -c dnf update -y  2>&1 && dnf install -y  openssl socat idn curl wget  2>&1" did not complete successfully: exit code: 1
------
 > [2/2] RUN dnf update -y  2>&1 && dnf install -y  openssl socat idn curl wget  2>&1:
1440.4   - Curl error (28): Timeout was reached for https://www.mageia.org/mirrorlist/?release=9&arch=x86_64&section=core&repo=updates [Connection timeout after ***00 ms]
1440.4   - Curl error (28): Timeout was reached for https://www.mageia.org/mirrorlist/?release=9&arch=x86_64&section=core&repo=updates [Failed to connect to www.mageia.org port 443 after ***00 ms: Timeout was reached]
1440.4 Error: Failed to download metadata for repo 'updates-x86_64': Cannot prepare internal mirrorlist: Curl error (28): Timeout was reached for https://www.mageia.org/mirrorlist/?release=9&arch=x86_64&section=core&repo=updates [Failed to connect to www.mageia.org port 443 after ***00 ms: Timeout was reached]
1440.4 Ignoring repositories: mageia-x86_64, updates-x86_64
1440.4 No match for argument: openssl
1440.4 No match for argument: socat
1440.4 No match for argument: idn
1440.4 Package curl-1:7.88.1-4.8.mga9.x86_64 is already installed.
1440.4 No match for argument: wget
1440.4 Error: Unable to find a match: openssl socat idn wget
------
Dockerfile:2
--------------------
   1 |     FROM mageia
   2 | >>> RUN dnf update -y  2>&1 && dnf install -y  \
   3 | >>> openssl socat idn curl wget  2>&1
   4 |     USER root
--------------------
ERROR: failed to build: failed to solve: process "/bin/sh -c dnf update -y  2>&1 && dnf install -y  openssl socat idn curl wget  2>&1" did not complete successfully: exit code: 1
mageia [FAIL]
[Tue Dec  9 16:50:59 UTC 2025] Failed: mageia
Error: Process completed with exit code 1.
##[debug]Finishing: Run acmetest

...and it passes so much first!
Thanks,

Bob

@rperper
Copy link
Author

rperper commented Dec 10, 2025

Can someone let me know if I'm wrong in believing that I've gone about as far in testing as I can go? Or is it expected that all tests will pass, each and every time if everything is right?

Thanks!

Bob

@rperper
Copy link
Author

rperper commented Dec 11, 2025

Now it's failing in FreeBSD, but it passed there earlier. So much is passing and the reasons for failing don't seem like DNS API bugs to me...

@rperper
Copy link
Author

rperper commented Dec 12, 2025

Run succeeded.

@rperper
Copy link
Author

rperper commented Dec 17, 2025

I really think it's ready to be approved. The workflow succeeded. Is there something I still need to do?

@rperper
Copy link
Author

rperper commented Dec 17, 2025

@adriangligor
@neilpang
Please let me know if there's something I need to do. Thanks so much!

dns_qc_add() {
fulldomain=$1
txtvalue=$2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check "if ! _exists jq " _err ""; and return 1

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neilpang I'm a little confused. Do you want me to verify that fulldomain and/or txtvalue are not JSON? Or that the response is JSON (perhaps right before line 106?).

Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if ! _exists jq; then

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neilpang Thanks for the explanation. I've pushed the update

@neilpang
Copy link
Member

it's not passing. https://github.com/rperper/acme.sh/actions/runs/20462958239/job/58799751194

you need to change the dockerfile to add jq.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants