Skip to content

Conversation

mbollmann
Copy link
Member

@mbollmann mbollmann commented Jun 8, 2025

This PR demonstrates how an ingestion script could be adapted to use the Python library.

NOTE: This branch was forked from https://github.com/acl-org/acl-anthology/tree/python-minimal-diff-xml-saving, so the commit history is currently quite noisy, and this shouldn't be merged before #5337 is.

Copy link

codecov bot commented Jun 8, 2025

Codecov Report

Attention: Patch coverage is 98.29060% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.75%. Comparing base (9302755) to head (cc1d452).

Files with missing lines Patch % Lines
python/acl_anthology/collections/event.py 92.85% 1 Missing ⚠️
python/acl_anthology/utils/xml.py 98.24% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           python-dev    #5359      +/-   ##
==============================================
+ Coverage       93.67%   93.75%   +0.08%     
==============================================
  Files              35       35              
  Lines            2781     2850      +69     
==============================================
+ Hits             2605     2672      +67     
- Misses            176      178       +2     
Files with missing lines Coverage Δ
python/acl_anthology/collections/__init__.py 100.00% <100.00%> (ø)
python/acl_anthology/collections/collection.py 97.61% <100.00%> (+0.89%) ⬆️
python/acl_anthology/collections/eventindex.py 92.95% <100.00%> (-0.20%) ⬇️
python/acl_anthology/collections/paper.py 92.41% <100.00%> (+0.10%) ⬆️
python/acl_anthology/collections/types.py 100.00% <100.00%> (ø)
python/acl_anthology/people/name.py 97.81% <100.00%> (-0.73%) ⬇️
python/acl_anthology/sigs.py 97.02% <100.00%> (ø)
python/acl_anthology/utils/git.py 76.27% <100.00%> (-6.78%) ⬇️
python/acl_anthology/venues.py 88.40% <100.00%> (ø)
python/acl_anthology/collections/event.py 99.20% <92.85%> (-0.80%) ⬇️
... and 1 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mbollmann
Copy link
Member Author

Ping @mjpost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant