Skip to content

Conversation

Azax4
Copy link
Collaborator

@Azax4 Azax4 commented May 28, 2025

Added ORCID and Hishest educational Institution fields to name correction template

@Azax4 Azax4 self-assigned this May 28, 2025
@Azax4 Azax4 requested a review from mjpost May 28, 2025 13:16
@Azax4 Azax4 added this to the 2025Q2 milestone May 28, 2025
@Azax4 Azax4 linked an issue May 28, 2025 that may be closed by this pull request
@mjpost mjpost changed the title Added ORCID and Hishest educational Institution fields to name correction template Added ORCID and Highest educational Institution fields to name correction template May 28, 2025
@mjpost
Copy link
Member

mjpost commented May 28, 2025

Thanks for jumping on this so quickly! When processing current open requests, we are going to have to ask for this manually, or figure out an automated solution.

@Azax4
Copy link
Collaborator Author

Azax4 commented May 28, 2025

Thanks for jumping on this so quickly! When processing current open requests, we are going to have to ask for this manually, or figure out an automated solution.

I can try to use a combination of https://docs.github.com/en/rest/issues/issues?apiVersion=2022-11-28#list-repository-issues to get all the open issues and https://docs.github.com/en/rest/issues/comments?apiVersion=2022-11-28#create-an-issue-comment to create a comment for all open issues where the title includes "Author page" then automatically leave a comment asking for ORCID and affiliation. The only main problem I can imagine would be tracking who has and hasn't provided the information after the comment.

@mjpost
Copy link
Member

mjpost commented May 28, 2025

That sounds great. I have a script that I used to close a number of requests when we switched to our automated system. I didn't check it in so I'll have to pull it from my other computer tonight. You can see bin/process_bulk_metadata.py for an example of how to use the Github module.

@mjpost
Copy link
Member

mjpost commented May 28, 2025

Another idea: edit each issue description to create the fields as the template would have done, and then add a bot comment to request them to update that. That way it would be in a uniform location.

@Azax4
Copy link
Collaborator Author

Azax4 commented May 28, 2025

Sounds good! I'll create a PR or two to test on and will run it after!

@nschneid
Copy link
Contributor

While we're at it, what about a "name in another orthography" field? And maybe a checkbox to indicate if it is a RTL script.

@mjpost
Copy link
Member

mjpost commented May 29, 2025

I would word this as id: author_name_script_variant with a description of "If you publish using your name written in a non-Latin script, please provide it here with a UTF-8 encoding". The field should be optional. Checkbox can be "Script is read right-to-left" (though maybe we can infer this?)

@nschneid
Copy link
Contributor

If you publish using your name written in a non-Latin script

I was thinking the purpose would also be to disambiguate names that are ambiguous in the Latin script (esp. Chinese names)

mjpost and others added 3 commits May 29, 2025 11:27
@Azax4
Copy link
Collaborator Author

Azax4 commented Jun 1, 2025

Added the fields!

@Azax4
Copy link
Collaborator Author

Azax4 commented Jun 1, 2025

I also have the script to edit existing Author Page issues and add a comment ready to run as soon as the template is finalized!

@mjpost mjpost merged commit 66f76f0 into master Jun 5, 2025
2 checks passed
@mjpost mjpost deleted the Add-ORCID-to-name-correction-template branch June 5, 2025 19:53
@mjpost
Copy link
Member

mjpost commented Jun 5, 2025

@Azax4 okay, this is merged. Let's see what it looks like, and we can see if any changes are desired.

You said you have code ready to add an annotation to existing issues. Can you create a new PR with the code, and test it out on #5349? Code should be added under bin/.

@mjpost
Copy link
Member

mjpost commented Jun 5, 2025

@Azax4 one issue here is that it's a bit of an overkill that the fields are textareas instead of smaller text fields. Can you see if normal text fields are an option? That would be more suitable for this new information.

@Azax4
Copy link
Collaborator Author

Azax4 commented Jun 9, 2025

Hi @mjpost , I have created the PR for both in #5367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author name template should prompt for ORCID and educational institution
4 participants