Use eager factory optimization only in production env (close #442)

[deepsweet]

As discussed in #442.

• We don't care about propTypes check anymore since it's already no-op in prod env.
• Notice few shallow → mount changes in tests – that's actually the confusion which I described in corresponding issue.

✌️

[codecov-io]

Codecov Report

Merging #473 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #473   +/-   ##
=======================================
  Coverage   88.86%   88.86%           
=======================================
  Files          53       53           
  Lines         386      386           
=======================================
  Hits          343      343           
  Misses         43       43

Impacted Files	Coverage Δ
...ose/isReferentiallyTransparentFunctionComponent.js	100% <ø> (ø)	⬆️
...packages/recompose/utils/createEagerElementUtil.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 828c36e...4a8535c. Read the comment docs.

[wuct]

The title of this PR and the commit should be "Use eager factory optimization only in production env ".

[deepsweet]

@wuct oops, fixed.

[wuct]

Looks good to me, thanks!

[wuct]

Hmmm, actually I think we should move the env check out of isReferentiallyTransparentFunctionComponent(), otherwise there is an abstraction leak.

[deepsweet]

Agreed. So both to createEagerFactory and createEagerElement?

[deepsweet]

Hm, looks like createEagerElementUtil is the right place.

[deepsweet]

Done.

I returned check for propTypes back because it's actually a part of abstraction, so this way it's not related to any env and concepts are divided. But optimization will not work even in production env if you have propTypes.

Options:

1. Remove check for propTypes from isReferentiallyTransparentFunctionComponent at all.
2. I'd like to work on something similar to babel-plugin-transform-react-remove-prop-types but for setPropTypes, I think it's a more proper way to achieve prod-only optimization.

WDYT?

[istarkov]

seems like break previous behaviour?

[istarkov]

IMO option 1 is preferred, having that it is fully compatible with previous behaviour in production mode.

[deepsweet]

Done.

[deepsweet]

isReferentiallyTransparentFunctionComponent returns true for functions that use propTypes

[istarkov]

Thank you