Reorder XLSX output fields in RESOURCES sheet #1546 #1590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aayushkdev We need a simple unit test to ensure the order does not get changed back later. |
aayushkdev
force-pushed
the
reorder-xlsx-fields-resources-1546
branch
2 times, most recently
from
8977308 to
2854b65
Compare
Signed-off-by: Aayush Kumar <[email protected]>
aayushkdev
force-pushed
the
reorder-xlsx-fields-resources-1546
branch
from
2854b65 to
8ea96e1
Compare
|
Hey @tdruez I've added the necessary tests, please check and see if its fit for merging. |
|
@aayushkdev Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1546