Fix React v16 prevContext issue #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook/react#8631 In React v16, prevContext is not longer passed only in componentDidUpdate, but in previous lifecycle it's present.
|
Thanks for that ! Looks good. I'll review and merge as soon as I can. It's pretty tense lately. |
|
Your tests didn't pass, as there was a lot of breaking changes with enzyme. Therefore I just merged a PR I did which upgrades to react 16, and also updates the tests with enzyme 3+. #18 should be fine, I'll publish it to npm in a sec ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
facebook/react#8631
In React v16, prevContext is not longer passed only in componentDidUpdate, but in previous lifecycle it's present.